Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some deprecated components with listeners/services #524

Merged
merged 5 commits into from
Apr 30, 2020
Merged

Replace some deprecated components with listeners/services #524

merged 5 commits into from
Apr 30, 2020

Conversation

mzarnowski
Copy link
Contributor

This migrates some of the existing project components to a more modern (and recommended) service/listener architecture.
Also, some other minor deprecations were fixed along the way

@mzarnowski mzarnowski marked this pull request as ready for review April 29, 2020 13:31
wisechengyi
wisechengyi approved these changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@wisechengyi wisechengyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Marek!

@wisechengyi wisechengyi merged commit 3d9dc39 into pantsbuild:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisechengyi wisechengyi wisechengyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzarnowski @wisechengyi